Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the format of data in Burndata #2136

Closed
cuongquangnam opened this issue Aug 3, 2023 · 2 comments · Fixed by #2137
Closed

Specify the format of data in Burndata #2136

cuongquangnam opened this issue Aug 3, 2023 · 2 comments · Fixed by #2137
Labels
kind/feature New feature request needs/area Needs area label(s) needs/triage Waiting for triage to be accepted

Comments

@cuongquangnam
Copy link
Contributor

cuongquangnam commented Aug 3, 2023

What would you like to be added:

In BurnData, the format for fields: paybackfees, paybacktokens, dfip2203 and dfip2206f are not clear.

Solution: according to these references, they should be in the format AMOUNT@SYMBOL.

  1. expect(burnInfoAfter.paybackfees).toStrictEqual([`${totalTslaPenalty.toFixed(8)}@TSLA`])
  2. expect(burnInfoAfter.paybacktokens).toStrictEqual([`${dusdPayback.toFixed(8)}@DUSD`])
  3. expect(burnAfter.dfip2203).toStrictEqual([`${swapAmount.toFixed(8)}@DUSD`])
  4. expect(burn.dfip2206f).toStrictEqual(['74.00000000@DFI']) // 30 + 44

Why is this needed:

@cuongquangnam cuongquangnam added the kind/feature New feature request label Aug 3, 2023
@github-actions github-actions bot added the needs/triage Waiting for triage to be accepted label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

@cuongquangnam: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added the needs/area Needs area label(s) label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

@cuongquangnam: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

thedoublejay pushed a commit that referenced this issue Aug 11, 2023
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #2136 

#### Additional comments?:

---------

Co-authored-by: Pierre Gee <pierre@cakedefi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request needs/area Needs area label(s) needs/triage Waiting for triage to be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant