feat(jellyfish-api-core): Add multi-txtype, multi-address query support for accounthistorycount RPC
#1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
apps/whale-api
area/apps
area/packages
kind/feature
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Code Climate has analyzed commit e45bcc3 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportBase: 59.81% // Head: 92.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
===========================================
+ Coverage 59.81% 92.52% +32.70%
===========================================
Files 290 357 +67
Lines 9331 10589 +1258
Branches 1251 1349 +98
===========================================
+ Hits 5581 9797 +4216
+ Misses 3528 754 -2774
+ Partials 222 38 -184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit db9e3d0
You can also get an immutable image with the commit hash
|
helloscoopa
requested review from
fuxingloh,
canonbrother,
ivan-zynesis,
kodemon and
eli-lim
as code owners
…storycount Signed-off-by: Dilshan Madushanka <helloscoopz@gmail.com>
|
need to also update docs |
infinia-yzl
previously approved these changes
Jan 3, 2023
marktanrj
previously approved these changes
Jan 4, 2023
fuxingloh
reviewed
Jan 5, 2023
packages/jellyfish-api-core/__tests__/category/account/accountHistoryCount.test.ts
Outdated
Show resolved
Hide resolved
helloscoopa
dismissed stale reviews from marktanrj and infinia-yzl
via
fe75304
fuxingloh
reviewed
Jan 6, 2023
…storycount Signed-off-by: Dilshan Madushanka <helloscoopz@gmail.com>
helloscoopa
requested review from
thedoublejay,
kyleleow and
pierregee
as code owners
…storycount Signed-off-by: Dilshan Madushanka <helloscoopz@gmail.com>
fuxingloh
requested review from
delphk,
marktanrj,
infinia-yzl and
fuxingloh
and removed request for
marktanrj
delphk
previously approved these changes
Jan 19, 2023
delphk
approved these changes
Jan 19, 2023
infinia-yzl
approved these changes
Jan 20, 2023
fuxingloh
approved these changes
Jan 20, 2023
fuxingloh
deleted the
dilshan/add-more-filter-options-to-accounthistorycount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As stated in the title, this PR adds support to
accounthistorycountRPC to query with multiple txtypes/addresses.We need this because with the current implementation we're only allowed to fetch one address and/or one tx type at once thus needing to make multiple RPC calls if we need to query history count of multple txtypes/addresses.
Refer: Defich/ain PR