feat(jellyfish-crypto): add fromAddress to convert eth address into script #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2134 +/- ##
==========================================
+ Coverage 91.33% 91.57% +0.23%
==========================================
Files 371 371
Lines 11180 11188 +8
Branches 1452 1453 +1
==========================================
+ Hits 10211 10245 +34
+ Misses 931 907 -24
+ Partials 38 36 -2
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Docker build preview for jellyfish/apps is ready! Built with commit 31d61d7
You can also get an immutable image with the commit hash
|
fullstackninja864
previously approved these changes
Aug 2, 2023
canonbrother
previously approved these changes
Aug 2, 2023
pierregee
previously approved these changes
Aug 2, 2023
fuxingloh
requested changes
Aug 7, 2023
lykalabrada
dismissed stale reviews from pierregee, canonbrother, and fullstackninja864
via
edace67
canonbrother
approved these changes
Aug 7, 2023
fuxingloh
approved these changes
Aug 7, 2023
pierregee
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To get EVM script for an ETH address that is not owned by the same wallet. Will be used on the
transferDomaintransaction builder that only accepts script as addressWhich issue(s) does this PR fixes?:
Fixes DFC-170
Additional comments?: