add new apps/ directory for deployable apps #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated ts config to modern flags
defichain-bot
added
area/jellyfish-api-jsonrpc
area/workflow
kind/chore
|
Code Climate has analyzed commit 240e4f4 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 240e4f4 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61b97816f31dc90007757338 😎 Browse the preview: https://deploy-preview-888--jellyfish-defi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 95.34% 96.35% +1.01%
==========================================
Files 140 134 -6
Lines 4486 4385 -101
Branches 586 566 -20
==========================================
- Hits 4277 4225 -52
+ Misses 209 160 -49
Continue to review full report at Codecov.
|
fuxingloh
requested review from
canonbrother,
ivan-zynesis and
monstrobishi
as code owners
chee-chyuan
approved these changes
Dec 15, 2021
canonbrother
approved these changes
Dec 15, 2021
ivan-zynesis
approved these changes
Dec 15, 2021
surangap
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind chore
What this PR does / why we need it:
Introduce a new
./apps/*directory for deployable apps. Examples of deployable apps are./website,./ocean-api, and./playground. Part of the #580 consolidation transition to create a better synergy of DeFiChain open-source development across concerns../modules/*(directory name undecided) will also be introduced in the later weeks to Rust Native Addon. @surangapEffectively with this PR and going hard with the monorepo design, we will have:
modules/*for internal modules JS Native Addon - Jellyfish Blockchaindocs/*all docs related to this project - Jellyfish Ecosystemexamples/*for all examples related to this project - Jellyfish Ecosystempackages/*all published SDK for Jellyfish Ecosystem & Jellyfish Walletapps/*for deployable apps/containers/web - Jellyfish Ecosystem & Jellyfish WalletWithin this PR, tsconfig and dependencies have been updated to modern settings/flags to make it easier to develop or use new features.