Fixing qualified name tests with nested. Fixing type with NestedFunct…

…ion. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Bit-Quill · Mar 22, 2023 · e5221ba · e5221ba
1 parent 4e4f4a4
commit e5221ba
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/core/src/main/java/org/opensearch/sql/expression/nested/NestedFunction.java b/core/src/main/java/org/opensearch/sql/expression/nested/NestedFunction.java
@@ -33,6 +33,6 @@ public ExprValue valueOf(Environment<Expression, ExprValue> valueEnv) {
 
   @Override
   public ExprType type() {
-    return this.arguments.get(0).type();
+    return  this.arguments.get(0).type();
   }
 }
diff --git a/core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java b/core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java
@@ -406,10 +406,6 @@ public void project_nested_field_arg() {
                 function("nested", qualifiedName("message", "info")), null)
         )
     );
-
-    Map<String, ReferenceExpression> fieldPathMap = Map.of(
-        "field", new ReferenceExpression("message.info", STRING),
-        "path", new ReferenceExpression("message", STRING));
   }
 
   @Test

diff --git a/sql/src/test/java/org/opensearch/sql/sql/parser/AstBuilderTest.java b/sql/src/test/java/org/opensearch/sql/sql/parser/AstBuilderTest.java
@@ -697,7 +697,7 @@ public void can_build_nested_select_field() {
             relation("test"),
             alias(
                 "message.info",
-                function("nested", qualifiedName("message.info")),
+                function("nested", qualifiedName("message", "info")),
                 null
             )
         ),

diff --git a/sql/src/test/java/org/opensearch/sql/sql/parser/AstExpressionBuilderTest.java b/sql/src/test/java/org/opensearch/sql/sql/parser/AstExpressionBuilderTest.java
@@ -216,7 +216,7 @@ public void canBuildGetFormatFunctionCall() {
   public void canBuildNestedFunctionWithFieldParam() {
     assertEquals(
         new Alias("message.info",
-            function("nested", qualifiedName("message.info"))),
+            function("nested", qualifiedName("message","info"))),
         buildExprAst("nested(message.info)")
     );
   }
@@ -226,7 +226,7 @@ public void canBuildNestedFunctionWithFieldAndPathParams() {
     assertEquals(
         new Alias("message.info",
             function("nested",
-                qualifiedName("message.info"),
+                qualifiedName("message", "info"),
                 qualifiedName("message"))),
         buildExprAst("nested(message.info, message)")
     );