-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated EXPM1() and Tests to New Engine #215
Conversation
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Actions are failing due to checkstyle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about PPL?
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
opensearch-project#1097 for reference |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## integ-expm1 #215 +/- ##
=================================================
- Coverage 98.36% 98.36% -0.01%
+ Complexity 3643 3636 -7
=================================================
Files 343 343
Lines 9017 8990 -27
Branches 585 585
=================================================
- Hits 8870 8843 -27
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…mentation Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
the checkstyle was failing because of the lack of a newline which I have now fixed |
I have added in PPL, including testing and documentation |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can rebase on upstream/main
to make CI pass
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
I have now rebased the changes |
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
I would suggest to have the math function base extraction be a part of a different task so that more tests can be included for each of the types that the functions supports. This would prevent the task and PR from becoming large. |
…d PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…ns to use the base Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…t work Signed-off-by: Matthew Wells <matthew.wells@improving.com>
docs/user/ppl/functions/math.rst
Outdated
@@ -321,7 +321,6 @@ Example:: | |||
| 7.38905609893065 | | |||
+------------------+ | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental deletion?
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Show resolved
Hide resolved
… pull request Signed-off-by: Matthew Wells <matthew.wells@improving.com>
… done in one commit Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
* Updated EXPM1() and tests to new engine Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…) (opensearch-project#1348) * Updated EXPM1() and tests to new engine Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit e990201) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells matthew.wells@improving.com
Description
Updated EXPM1 function to run on the new engine, as well as added integration tests and unit tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.