Legacy fall back with JSON format #237

GumpacG · 2023-03-02T00:49:57Z

NOTE

Actions are expected to fail as the migration of tests will be part of a separate PR.
Jacoco will fail on OpenSearchExecutionEngine and will be fixed in the parent PR as there may be improvements that can be done.

Description

JSON implementation comes from PR #217.
JSON format for V2 does not support and falls back to legacy for the following:

Cast
Literals
Aggregation in group by
In memory operations
Hints

TODO before being able to merge to upstream main:

DateFormatIT. and
DateFormatIT. equalTo
DateFormatIT. greaterThan
DateFormatIT. greaterThanOrEqualTo
DateFormatIT. lessThan
DateFormatIT. lessThanOrEqualTo
DateFormatIT. or
DateFormatIT. sortByDateFormat
QueryFunctionsIT. wildcardQuery (Dependent on PR #1314)
QueryIT. dateBetweenSearch
QueryIT. dateSearch
QueryIT. selectAllWithFieldAndOrderBy
QueryIT. selectAllWithFieldReturnsAll
QueryIT. selectAllWithFieldReverseOrder
QueryIT. selectAllWithMultipleFields
QueryIT. inTest (mismatch with legacy result due to lack of score function. Can be ignored for now as score implementation is in progress)
QueryIT. notLikeTests (mismatch with legacy result due to lack of score function. Can be ignored for now as score implementation is in progress)

Issues Resolved

opensearch-project#1317

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sql/src/main/java/org/opensearch/sql/sql/SQLService.java

sql/src/main/java/org/opensearch/sql/sql/antlr/SQLSyntaxParser.java

sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java

sql/src/test/java/org/opensearch/sql/sql/SQLServiceTest.java

ppl/src/test/java/org/opensearch/sql/ppl/PPLServiceTest.java

sql/src/main/java/org/opensearch/sql/sql/SQLService.java

forestmvey · 2023-03-02T15:55:10Z

sql/src/main/java/org/opensearch/sql/sql/SQLService.java

+
+      if (!isJsonSupported) {
+        throw new UnsupportedOperationException(
+            "Queries with aggregation and in memory operations (cast, literals, alias, math, etc.)"


Curious what of these are supported in legacy engine with JSON format?

All of those are supported in legacy because they are pushed down.

For slightly better error messaging, throw the errors in JsonSupportAnalyzer and you can say what type of functions are unsupported as the node visitor reaches an unsupported node.

I've made each unsupported node visitor throw the exception in 74f88ae. Thanks!

codecov · 2023-03-02T23:27:54Z

Codecov Report

Merging #237 (3335354) into dev-v2-json-support (c4395d6) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##             dev-v2-json-support     #237      +/-   ##
=========================================================
+ Coverage                  98.30%   98.39%   +0.09%     
- Complexity                  3691     3713      +22     
=========================================================
  Files                        344      346       +2     
  Lines                       9125     9164      +39     
  Branches                     585      588       +3     
=========================================================
+ Hits                        8970     9017      +47     
+ Misses                       150      142       -8     
  Partials                       5        5

Flag	Coverage Δ
sql-engine	`98.39% <100.00%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rg/opensearch/sql/analysis/JsonSupportVisitor.java	`100.00% <100.00%> (ø)`
...search/sql/analysis/JsonSupportVisitorContext.java	`100.00% <100.00%> (ø)`
...c/main/java/org/opensearch/sql/sql/SQLService.java	`100.00% <100.00%> (ø)`
.../org/opensearch/sql/sql/antlr/SQLSyntaxParser.java	`100.00% <100.00%> (ø)`

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

core/src/main/java/org/opensearch/sql/analysis/JsonSupportAnalyzer.java

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

…format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

This reverts commit 17684b3.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

…format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

acarbonetto · 2023-03-06T17:16:20Z

sql/src/main/java/org/opensearch/sql/sql/antlr/SQLSyntaxParser.java

@@ -32,4 +32,9 @@ public ParseTree parse(String query) {
    return parser.root();
  }

+  public boolean containsHints(String query) {


Longer term, we want to return hints... not whether the parser contains hints.
Maybe, return the whole list now and check the conditional hintsParser.root().getChildCount() > 1 in the calling function.

Thanks. Changed this in 74f88ae

acarbonetto · 2023-03-06T17:27:14Z

core/src/main/java/org/opensearch/sql/analysis/JsonSupportAnalyzer.java

+import org.opensearch.sql.ast.tree.Filter;
+import org.opensearch.sql.ast.tree.Project;
+
+public class JsonSupportAnalyzer extends AbstractNodeVisitor<Boolean, Object> {


JsonSupportNodeVisitor? I'm not sure why we call things "analyzers" when they're node visitors.

<Boolean, Object> doesn't seem correct, but I suppose we don't really have a ned for a context yet, nor a return type (which is usually a Plan or OptimizedTree.
If the purpose of the node visitor is just to find unsupported nodes, then I suppose this is fine but we should include a javadoc comment that details this.

Longer term, we may consider using this to return a JSON object or a tree that can be turned into a JSON object.
We can remove the Boolean return type if we throw Exceptions in the node visitors.
If not, we should be returning Boolean types, not boolean types. Example, Boolean.TRUE.

Thanks. Changed this in 74f88ae and 6785f23.
I've made each unsupported node visitor throw an exception so there is no more use for return type boolean. However The abstract class requires a return type so I left it as Boolean.

acarbonetto · 2023-03-06T17:30:38Z

sql/src/main/java/org/opensearch/sql/sql/SQLService.java

+
+      if (!isJsonSupported) {
+        throw new UnsupportedOperationException(
+            "Queries with aggregation and in memory operations (cast, literals, alias, math, etc.)"


For slightly better error messaging, throw the errors in JsonSupportAnalyzer and you can say what type of functions are unsupported as the node visitor reaches an unsupported node.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

MaxKsyunz · 2023-03-08T06:38:38Z

sql/src/test/java/org/opensearch/sql/sql/SQLServiceTest.java

+
+  @Test
+  public void canThrowUnsupportedExceptionForFunctionJsonQuery() {
+    sqlService.execute(


This block of code is common to all the tests, isn't it? They only differ in query sent.

Can you put it in a utility method that's call by the tests?

You can make it even more compact by creating a parameterized test that takes a list of sql statement to test.

Thanks, changed in e0e2365. Please let me know if you had something else in mind.

MaxKsyunz

Are there unit tests for JsonSupportVisitor class?

A lot of it is flagged as lacking test coverage.

MaxKsyunz · 2023-03-08T06:46:33Z

Also, DCO check is failing, these changes will need to be squashed before going to upstream.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG · 2023-03-10T19:15:47Z

Are there unit tests for JsonSupportVisitor class?

A lot of it is flagged as lacking test coverage.

Added in 232196d

GumpacG · 2023-03-10T19:16:20Z

Also, DCO check is failing, these changes will need to be squashed before going to upstream.

Thanks for the heads up. I'm hoping to squash and merge and have DCO check pass then.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG · 2023-03-13T18:19:05Z

core/src/main/java/org/opensearch/sql/analysis/JsonSupportVisitor.java

+ * Unsupported features in V2 are ones the produce results that differ from
+ * legacy results.
+ */
+public class JsonSupportVisitor extends AbstractNodeVisitor<Boolean, JsonSupportVisitorContext> {


Change type to Void and only throw exceptions.

Addressed in c2cb0f3

GabeFernandez310

Looks fine to me so far, but I'll wait until you address what we talked about this morning before approving.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG · 2023-03-13T20:35:49Z

Looks fine to me so far, but I'll wait until you address what we talked about this morning before approving.

Addressed in c2cb0f3

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GabeFernandez310 · 2023-03-13T22:17:45Z

sql/src/main/java/org/opensearch/sql/sql/SQLService.java

@@ -30,7 +30,7 @@
 @RequiredArgsConstructor
 public class SQLService {

-  private final SQLSyntaxParser parser;
+  private final SQLSyntaxParser parser;sq


Typo?

Suggested change

private final SQLSyntaxParser parser;sq

private final SQLSyntaxParser parser;

Yes. Fixed in 9233d7c. Thanks

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Implement json support for V2 engine Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Reverted some changes Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Removed some fields Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * minor fix Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Added a unit test, cleaned up Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Returning raw OpenSearch response when type is json Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Add an integration test, fix checkstyle errors Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Made new engine fallback to legacy for in memory operations for json format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address build failures Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Added legacy fall back Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Refactored fall back logic to use visitor design pattern Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary IT Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR feedback Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary context Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added fall back for Filter functions Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Made new engine fallback to legacy for in memory operations for json format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address build failures Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Added legacy fall back Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Refactored fall back logic to use visitor design pattern Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary IT Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR feedback Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary context Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added fall back for Filter functions Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Fixed checkstyle errors Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments and fixed the visitor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added comment to visitor class Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments to improve visitor class Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests for JsonSupportVisitor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added helper function for SQLServiceTest Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added expected failures Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Reworked the visitor class to have type Void instead of Boolean Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Fixed typo Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added github link for tracking issue Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Margarit Hakobyan <margarit.hakobyan@improving.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>

* Implement json support for V2 engine Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Reverted some changes Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Removed some fields Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * minor fix Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Added a unit test, cleaned up Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Returning raw OpenSearch response when type is json Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Add an integration test, fix checkstyle errors Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Added constructor for empty rawResponse Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added constant for supported formats Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit test Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments: Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Fixed issue Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added getter for rawResponse in PhysicalPlan Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Legacy fall back with JSON format (#237) * Implement json support for V2 engine Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Reverted some changes Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Removed some fields Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * minor fix Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Added a unit test, cleaned up Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Returning raw OpenSearch response when type is json Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Add an integration test, fix checkstyle errors Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> * Made new engine fallback to legacy for in memory operations for json format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address build failures Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Added legacy fall back Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Refactored fall back logic to use visitor design pattern Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary IT Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR feedback Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary context Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added fall back for Filter functions Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Made new engine fallback to legacy for in memory operations for json format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address build failures Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Added legacy fall back Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Refactored fall back logic to use visitor design pattern Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary IT Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR feedback Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary context Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added fall back for Filter functions Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Fixed checkstyle errors Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments and fixed the visitor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added comment to visitor class Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments to improve visitor class Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit tests for JsonSupportVisitor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added helper function for SQLServiceTest Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added expected failures Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Reworked the visitor class to have type Void instead of Boolean Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Fixed typo Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added github link for tracking issue Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Margarit Hakobyan <margarit.hakobyan@improving.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com> * Reverted OpenSearchIndexScan changes as it broke IT Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added unit test Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unused Mock variable Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com> Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>

GumpacG requested a review from a team March 2, 2023 00:49

Yury-Fridlyand reviewed Mar 2, 2023

View reviewed changes

forestmvey reviewed Mar 2, 2023

View reviewed changes

sql/src/main/java/org/opensearch/sql/sql/SQLService.java Outdated Show resolved Hide resolved

forestmvey reviewed Mar 2, 2023

View reviewed changes

Yury-Fridlyand reviewed Mar 2, 2023

View reviewed changes

core/src/main/java/org/opensearch/sql/analysis/JsonSupportAnalyzer.java Outdated Show resolved Hide resolved

core/src/main/java/org/opensearch/sql/analysis/JsonSupportAnalyzer.java Outdated Show resolved Hide resolved

GumpacG force-pushed the dev-v2-json-support branch from 6e16fcc to 682110f Compare March 3, 2023 22:55

margarit-h and others added 17 commits March 3, 2023 14:56

Implement json support for V2 engine

9f2ad1d

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Reverted some changes

3167ee5

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Removed some fields

5e7a28d

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

minor fix

ab98db4

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Added a unit test, cleaned up

26920d0

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Returning raw OpenSearch response when type is json

543773e

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Add an integration test, fix checkstyle errors

3f23122

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>

Made new engine fallback to legacy for in memory operations for json …

1365ae0

…format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Address build failures

8e43ba6

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

Added legacy fall back

799a4ce

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Refactored fall back logic to use visitor design pattern

a82de60

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added unit tests

f11274f

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Revert "Address build failures"

16af6ea

This reverts commit 17684b3.

Removed unnecessary IT

7a782c7

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Addressed PR feedback

52a3c99

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Removed unnecessary context

b676acd

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added fall back for Filter functions

f7c5ee6

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG force-pushed the dev-json-fallback branch from 20a17a0 to f7c5ee6 Compare March 3, 2023 22:57

GumpacG and others added 5 commits March 3, 2023 15:06

Made new engine fallback to legacy for in memory operations for json …

bdb0ff6

…format Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Address build failures

7b4fea1

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

Added legacy fall back

581e7fe

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Refactored fall back logic to use visitor design pattern

d882830

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added unit tests

7ecc76e

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG mentioned this pull request Mar 6, 2023

Add JSON Support to V2 Engine #217

Merged

6 tasks

Fixed checkstyle errors

bee2102

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

acarbonetto reviewed Mar 6, 2023

View reviewed changes

GumpacG added 2 commits March 7, 2023 08:55

Addressed PR comments and fixed the visitor

74f88ae

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added comment to visitor class

6785f23

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

MaxKsyunz reviewed Mar 8, 2023

View reviewed changes

GumpacG marked this pull request as draft March 8, 2023 14:18

GumpacG added 3 commits March 9, 2023 15:01

Addressed PR comments to improve visitor class

9e733aa

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added unit tests for JsonSupportVisitor

232196d

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added helper function for SQLServiceTest

e0e2365

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG marked this pull request as ready for review March 10, 2023 20:26

Added expected failures

b60da69

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG commented Mar 13, 2023

View reviewed changes

GabeFernandez310 reviewed Mar 13, 2023

View reviewed changes

Reworked the visitor class to have type Void instead of Boolean

c2cb0f3

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Resolved merge conflicts

3bd7865

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GabeFernandez310 reviewed Mar 13, 2023

View reviewed changes

Fixed typo

9233d7c

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GabeFernandez310 approved these changes Mar 13, 2023

View reviewed changes

MaxKsyunz approved these changes Mar 14, 2023

View reviewed changes

Added github link for tracking issue

3335354

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG merged commit 4eb0618 into dev-v2-json-support Mar 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Legacy fall back with JSON format #237

Legacy fall back with JSON format #237

GumpacG commented Mar 2, 2023 •

edited

Loading

forestmvey Mar 2, 2023

GumpacG Mar 2, 2023

acarbonetto Mar 6, 2023

GumpacG Mar 7, 2023

codecov bot commented Mar 2, 2023 •

edited

Loading

acarbonetto Mar 6, 2023

GumpacG Mar 7, 2023

acarbonetto Mar 6, 2023

acarbonetto Mar 6, 2023

acarbonetto Mar 6, 2023

GumpacG Mar 7, 2023

acarbonetto Mar 6, 2023

MaxKsyunz Mar 8, 2023

GumpacG Mar 10, 2023

MaxKsyunz left a comment

MaxKsyunz commented Mar 8, 2023

GumpacG commented Mar 10, 2023

GumpacG commented Mar 10, 2023

GumpacG Mar 13, 2023

GumpacG Mar 13, 2023

GabeFernandez310 left a comment

GumpacG commented Mar 13, 2023

GabeFernandez310 Mar 13, 2023

GumpacG Mar 13, 2023

	private final SQLSyntaxParser parser;sq
	private final SQLSyntaxParser parser;

Legacy fall back with JSON format #237

Legacy fall back with JSON format #237

Conversation

GumpacG commented Mar 2, 2023 • edited Loading

NOTE

Description

Issues Resolved

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 2, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaxKsyunz left a comment

Choose a reason for hiding this comment

MaxKsyunz commented Mar 8, 2023

GumpacG commented Mar 10, 2023

GumpacG commented Mar 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GabeFernandez310 left a comment

Choose a reason for hiding this comment

GumpacG commented Mar 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GumpacG commented Mar 2, 2023 •

edited

Loading

codecov bot commented Mar 2, 2023 •

edited

Loading