Unify FFI calls with an example on C# #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
reviewed
Feb 23, 2024
| @@ -94,6 +98,16 @@ private void FailureCallback(ulong index) | |||
|
|
|||
| #region FFI function declarations | |||
|
|
|||
| public enum RequestType : uint | |||
There was a problem hiding this comment.
can we remove that and share the RequestType in the header file?
I'm not sure we need to convert from RequestType to RequestType to Cmd when it's 1:1:1.
There was a problem hiding this comment.
It is possible. We can define the enum into a C header file and then import it to C# project and to rust (using bindgen).
We can also use protoc to do this for us and suppress a warning about not-FFI-safe enum.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
aaron-congo
reviewed
Mar 4, 2024
Yury-Fridlyand
commented
Mar 7, 2024
| ) -> Result<Vec<String>, Utf8Error> { | ||
| from_raw_parts(data, len) | ||
| .iter() | ||
| .map(|arg| CStr::from_ptr(*arg).to_str().map(ToString::to_string)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C signature of new FFI function is