frontend: rotate default currency on account summary #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
requested changes
Mar 18, 2024
|
When I rotate the fiat is a bit unstable and seems to change a few times, I haven't investigated .. do you see that too? |
shonsirsha
force-pushed
the
frontend-rotate-fiat-account-summary
branch
from
97d0ef9 to
c979515
Compare
shonsirsha
commented
Mar 19, 2024
|
thx for the review as usual, PTAL 🙏 @thisconnect |
shonsirsha
force-pushed
the
frontend-rotate-fiat-account-summary
branch
from
931097b to
9f57a41
Compare
|
tested qt-osx and it looks good, but I want to take a bit more time to look at the changes in frontends/web/src/contexts/RatesProvider.tsx |
thisconnect
reviewed
Mar 19, 2024
thisconnect
approved these changes
Mar 19, 2024
to improve UX, we'd like to enable rotating default currency on account summary. This is done by: - creating DefaultCurrencyRotator component - reused that component in rates.tsx and chart.tsx - onClick, runs `rotateFiat` (`RatesContext`). - reinitialize chart on change `defaultCurrency` (`RatesContext`)
shonsirsha
force-pushed
the
frontend-rotate-fiat-account-summary
branch
from
3001bce to
85e72c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to improve UX, we'd like to enable rotating default currency on account summary. This is done by:
rotateFiat(RatesContext).defaultCurrency(RatesContext)