Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the DSL version of Plonk #138

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

weikengchen
Copy link
Contributor

This PR replaces and removes the previous implementation that is not using DSL and now uses the DSL version of the code. Some documentation and README will follow.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 96.15885% with 59 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/dsl/plonk/part1_fiat_shamir1.rs 95.23% 6 Missing ⚠️
...l/plonk/per_query_part5_num_interaction_shifted.rs 87.23% 6 Missing ⚠️
src/dsl/plonk/hints/fiat_shamir.rs 97.10% 5 Missing ⚠️
src/dsl/plonk/per_query_part7_num_interaction2.rs 90.90% 5 Missing ⚠️
...dsl/plonk/part2_fiat_shamir2_and_constraint_num.rs 93.10% 4 Missing ⚠️
src/dsl/plonk/per_query_part1_folding.rs 90.69% 4 Missing ⚠️
src/dsl/plonk/per_query_part8_last_step.rs 78.94% 4 Missing ⚠️
src/dsl/plonk/per_query_part2_num_trace.rs 94.82% 3 Missing ⚠️
src/dsl/plonk/per_query_part3_num_constant.rs 94.82% 3 Missing ⚠️
src/dsl/plonk/per_query_part4_num_composition.rs 93.33% 3 Missing ⚠️
... and 10 more
Files with missing lines Coverage Δ
src/algorithms/column_line_coeffs.rs 100.00% <100.00%> (ø)
src/algorithms/folding.rs 100.00% <100.00%> (ø)
src/algorithms/pair_vanishing.rs 100.00% <100.00%> (ø)
src/algorithms/point.rs 100.00% <100.00%> (ø)
src/algorithms/quotient.rs 100.00% <100.00%> (ø)
src/constraints/mod.rs 80.64% <ø> (-19.36%) ⬇️
src/dsl/plonk/hints/fold.rs 100.00% <100.00%> (ø)
src/dsl/plonk/hints/mod.rs 100.00% <100.00%> (ø)
src/dsl/plonk/hints/prepare.rs 100.00% <100.00%> (ø)
src/dsl/plonk/hints/quotients.rs 100.00% <100.00%> (ø)
... and 25 more

... and 1 file with indirect coverage changes

@weikengchen weikengchen merged commit fc7887b into Bitcoin-Wildlife-Sanctuary:main Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant