Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44Rejected?This is the other pull request. #46 is the other one.
In this particular pull request, we add an onion oracle, i.e. send a notification containing the payment hash and forwarding onion. Of note is that the forwarding onion is needed to support "stateless" invoices where the
payment_secret
and/ormetadata
is used to store important payment details. In particular, LDK out-of-the-box supports only stateless invoices (payment preimages are the HMAC of thepayment_secret
using the node secret key as MAC key). Like #37 (LSPS4) this requires that HTLCs be held at the LSP which the client responds to. Differences are: