Project enhancement: Exclude sb-vite from optimizeDeps
#15
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
changed the title
sb-vite from optimizeDepssb-vite from optimizeDeps
mejiaj
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I'm not seeing this issue locally, but open to merging. Not seeing anything wrong with this either, so open to merging — I am seeing this now:
Doesn't seem like a big deal, but didn't find anything meaningful online.
Sourcemap for "/virtual:/@storybook/builder-vite/setup-addons.js" points to missing source files
Sourcemap for "/virtual:/@storybook/builder-vite/vite-app.js" points to missing source filesFWIW, feel free to update & merge if you feel it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
main.jsto excludesb-vitefrom dependency optimization, to prevent a build error.Work is based on the example configuration in the Storybook Vite documentation
Closes #14