Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for umbrella projects #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beatrizChagas
Copy link

Motivation

When working with an umbrella project and performing Envy.reload_config/0 we got an exception because umbrella projects define their configuration at the root path instead of hardcoded config/config.exs.

Proposed Solution

Relies on Mix.Project.config/0 to fetch project metadata and access :config_path. This key is always present even if it is not defined in mix.exs, so it will work on both Elixir applications (umbrella or standalone).

Additional details

  • After running mix deps.get, mix.lock was updated automatically.
  • Could you suggest an approach to write a unit test for Envy.reload_config/0?

After running mix deps.get, mix.lock was updated automatically.
Copy link

@wevtimoteo wevtimoteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☔ ☂️ 🌂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants