Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBSELECT fetch strategy doesn't work with LIMIT/OFFSET or ORDER BY select aliases #370

Closed
beikov opened this issue Mar 6, 2017 · 0 comments · Fixed by #1356
Closed

SUBSELECT fetch strategy doesn't work with LIMIT/OFFSET or ORDER BY select aliases #370

beikov opened this issue Mar 6, 2017 · 0 comments · Fixed by #1356
Assignees
@beikov
Labels
component: entity-view kind: bug worth: low Implementing this has a low worth
Milestone
1.6.3

Comments

@beikov
Copy link
Member

beikov commented Mar 6, 2017

Currently we simply copy the base query for implementing the subselect strategy but this has some limitations. If the base query uses select aliases in the order by clause, it won't work because we strip off the select items although we should actually append only the necessary ones to the end of the query.
When a subview is correlated that contains collections, the use of limit and offset is broken currently when having a normal CriteriaBuilder. We should detect the use of collections somehow and convert the CriteriaBuilder to a PaginatedCriteriaBuilder via page() in that case.
@beikov beikov added this to the 1.2.0 milestone Mar 6, 2017
@beikov beikov self-assigned this Mar 6, 2017
@beikov beikov modified the milestones: 1.2.0, 1.3.0 Jan 28, 2018
@beikov beikov mentioned this issue Jan 23, 2019
Closed
@beikov beikov added the worth: low Implementing this has a low worth label Sep 20, 2020
@beikov beikov modified the milestones: 1.6.0, 1.6.x May 16, 2021
@beikov beikov modified the milestones: 1.6.x, 1.6.3 Sep 14, 2021
@beikov beikov mentioned this issue Sep 14, 2021
Merged
beikov added a commit to beikov/blaze-persistence that referenced this issue Sep 15, 2021
@beikov
[Blazebit#370, Blazebit#1357] Fix entity view pagination issue with j…
a74b105 
…oined collection and subselect fetching and implement support for subselect fetching when main query builder has LIMIT/OFFSET and/or ORDER BY clause
beikov added a commit to beikov/blaze-persistence that referenced this issue Sep 16, 2021
@beikov
[Blazebit#370, Blazebit#1357] Fix entity view pagination issue with j…
ccaec82 
…oined collection and subselect fetching and implement support for subselect fetching when main query builder has LIMIT/OFFSET and/or ORDER BY clause
beikov added a commit to beikov/blaze-persistence that referenced this issue Sep 16, 2021
@beikov
[Blazebit#370, Blazebit#1357] Fix entity view pagination issue with j…
69cfee0 
…oined collection and subselect fetching and implement support for subselect fetching when main query builder has LIMIT/OFFSET and/or ORDER BY clause
beikov added a commit that referenced this issue Sep 25, 2021
@beikov
[#370, #1357] Fix entity view pagination issue with joined collection…
f306298 
… and subselect fetching and implement support for subselect fetching when main query builder has LIMIT/OFFSET and/or ORDER BY clause
beikov added a commit to beikov/blaze-persistence that referenced this issue Nov 4, 2024
@beikov
[Blazebit#370, Blazebit#1357] Fix entity view pagination issue with j…
aba7dd6 
…oined collection and subselect fetching and implement support for subselect fetching when main query builder has LIMIT/OFFSET and/or ORDER BY clause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beikov beikov

Labels
component: entity-view kind: bug worth: low Implementing this has a low worth
Projects
None yet
Milestone
1.6.3
Development

Successfully merging a pull request may close this issue.

Various fixes beikov/blaze-persistence
1 participant
@beikov