[#1436] Fix boot issue when model contains an association to an entity type that has an id class #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an entity type that has an id class
msavy
reviewed
Jan 26, 2022
There was a problem hiding this comment.
If I understand this correctly, you manually try to resolve the dot path in the case of the exception we see today (blah.id for example); if that manual resolution fails, then you re-throw the exception.
That seems a very reasonable solution.
Thanks for looking at this so quickly!
|
Yes, that's what I am doing here. Thanks for the great reproducer @msavy! Reproducers like that always make it a breeze to figure out stuff like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #1436
Motivation and Context