Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client helpers use client properties #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eylles
Copy link
Contributor

@eylles eylles commented Jan 9, 2022

changed the _client.turn_off() and _client.turn_on() helpers to use the c.hidden property instead of the tagging/untagging dance in accordance to a comment in #140

so far this seems to work or the swallowing module and i haven't found any particular new corner case

testing for scratchpads and the tabbed module need to be done.

@eylles eylles mentioned this pull request Jan 10, 2022
@Nooo37
Copy link
Member

Nooo37 commented Jan 23, 2022

Works surprisingly fine for me. Sadly one exception I found are scratchpads where animations break in some cases (some incomming animations I think). The module probably checks for whether the scrachpad is already on the tag, which is true for this PR but false for the current code

@eylles
Copy link
Contributor Author

eylles commented Jan 24, 2022

hmmmm how about creating 2 sets of helpers, one just for the scratchpads and the other for everything else?

or perhaps have another argument for the helper that is only passed on the scratchpads module?

@eylles
Copy link
Contributor Author

eylles commented Aug 8, 2024

soon™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants