Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect Ratio option not used when using AutoCrop after amiberry 5.6.7 #1235

Closed
Retro1968 opened this issue Mar 7, 2024 · 4 comments
Closed
Assignees
Labels

Comments

@Retro1968
Copy link

Retro1968 commented Mar 7, 2024

Hello Dimitris, I would first like to thank you very much for your work on amiberry and the release of version 5.6.8.

I would now like to describe my problem to you. Up to version amiberry 5.6.6 I was able to achieve a real full screen
on my 4:3 LCD monitor with the right settings, as you can see in this screenshot.
Fullscreen with amiberry566

Since amiberry version 5.6.7 this is no longer possible. Black bars appear at the top and bottom, as you can see in this screenshot.
since_amiberry567

I use a Raspberry Pi 4B and tested on RaspiOS Bullseye 64 bit and on RetroPie 4.8.2. Here I am sending you my config files.
conf.zip

Cheers
Retro1968

@midwan midwan self-assigned this Mar 7, 2024
@midwan
Copy link
Collaborator

midwan commented Mar 7, 2024

The description is a bit misleading: Full-screen/full-window do still work with the latest versions.
Are you perhaps referring to aspect ratio correction?

How are you running the game? WHDLoad? Some games have settings being parsed from the XML, which might change Width/Height values (which ends up changing the cropped picture, which also changes the aspect ratio).

@midwan
Copy link
Collaborator

midwan commented Mar 7, 2024

Also, I cannot recreate this: Testing on a 1080p panel, I have no black borders at the top/bottom of the screen here. AutoCrop is enabled for this game, if you run it with the WHDBooter (.lha file), and AutoCrop has been a feature that was vastly improved in the latest versions.

I don't know if you have your own config for the game however, which would override the settings.

@Retro1968
Copy link
Author

I have already sent you my config files. The setting is therefore global. The games do not need to be configured individually. I use AmigaOS 3.2.2.1 and start the WHDLoad games via iGame. Until version 5.6.6, ALL games were automatically expanded to the entire screen. Why are you trying this in 1080? I use a 4:3 monitor. Please take the details from my config files and please test with my settings. Since 5.6.7 this no longer works. I have shown the problem in my two pictures.

@midwan midwan changed the title No Fullscreen possible since amiberry 5.6.7 Aspect Ratio option not used when using AutoCrop after amiberry 5.6.7 Mar 7, 2024
@midwan midwan closed this as completed in ee41310 Mar 7, 2024
@midwan midwan added bug and removed can't recreate labels Mar 7, 2024
@midwan
Copy link
Collaborator

midwan commented Mar 7, 2024

Fixed with the commits above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants