bugfix: remove newlines from debugger input #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "fd" command didn't work in the debugger. This was because the "d" was followed in the input buffer by \n rather than \0. The Windows version of console_get replaces the terminating \r with \0. amiberry's version uses fgets, which doesn't do this; it did adjust the length value returned, but the debugger code doesn't look at the length. Make it actually strip the newline characters when adjusting the length.
midwan
pushed a commit
that referenced
this pull request
Aug 26, 2024
The "fd" command didn't work in the debugger. This was because the "d" was followed in the input buffer by \n rather than \0. The Windows version of console_get replaces the terminating \r with \0. amiberry's version uses fgets, which doesn't do this; it did adjust the length value returned, but the debugger code doesn't look at the length. Make it actually strip the newline characters when adjusting the length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
fdcommand in the debugger didn't work, because the debugger code expects thedto be followed by\0in the input buffer. Fix amiberry's version ofconsole_getto strip newline characters from the end of the string it returns, as the Windows version does (rather than just adjusting the length value).@midwan