Support Node.js 13.x

[sam-github]

Builds and passes tests on Ubuntu with 13.x.

Also fixes many deprecations. A few outstanding deprecations related to
integrating with the new async context tracking API remain, so
continuation-local-storage may (still) not work (have not checked).

Fixes: #733

---

This was a fairly mechanical fix, I'm not that familiar with the code or usage.

I noticed that npm test is passing but make is not, which concerned me, but it turns out the same is true for master. So, I'm still concerned :-), but it isn't a problem intoduced by this PR AFAICT.

[sam-github]

@iradul and perhaps @davidtrihy since you have C++ experience according to #628 (comment)

[iradul]

Thank you for this PR!

[sam-github]

I'll figure out the conflicts tomorrow and rebase.

[skairali]

+1

[sam-github]

Builds on <8.x now.

[csantanapr]

Thank you for this PR 👍

[iradul]

Some e2e tests are failing on v13. I'll have investigate this.

[sam-github]

@iradul I didn't find info on how to run the e2e tests, I'll take a shot at fixing issues if I know how to reproduce.

[IdanAdar]

@iradul can you help out here?

[iradul]

@iradul I didn't find info on how to run the e2e tests, I'll take a shot at fixing issues if I know how to reproduce.

You first need to start local Kafka, you can use provided docker-compose -d up for that. Also, you may need to run it twice or so until Kafka is actually up. This is because sometimes Zookeeper boots slowly and then Kafka fails to load.

After you have Kafka running on localhost:9092, you just do make e2e to run the tests.

[iradul]

I'll merge this since the e2e test issue (an empty string Buffer becomes null) is related to a change in v13 NodeJS/V8 code base and how it handles zero length Buffer. It's reported here.
I have a workaround that I'll commit soon.

[sam-github]

Thanks for looking at this @iradul

[ntkumar1]

@iradul When can we expect next version of rdkafka with node.js 13 support