Improve type definitions for config callbacks #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with strict type checking in typescript, the callbacks
dr_cb
,rebalance_cb
andoffset_commit_cb
are not sufficiently typed, and even the examples given in the README are throwing type errors.This PR defines strict types for these callbacks.
I have done my best to back track the types from the
EventListenerMap
forrebalance
,offset.commit
anddelivery-report
Caveat 1: I have not been able to build the project locally, so these changes are made based on the installed package from npm inside a project that consumes node-rdkafka
Caveat 2:. In my project, I am currently only using
rebalance_cb
, so the others have been harder to check.