Migrate _import_protocol to importlib #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good change, users of Python 2 can rely on the older releases. I haven't worked at Blizzard for over 4 years so I can't push this PR forward. I think a PR that would help this move forward would be to refactor travis to github actions. This would allow the tox job to run in the context of this PR and provide an easier path to merging. I would be surprised if the travis-ci stuff was still active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
_import_protocoluses the deprecated imp library which was removed in Python 3.12. This PR reimplements_import_protocolwith the superseding importlib library to allow compatibility with newer versions of Python.