Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Display Items' dropdown in PaginatedTable change not working #488

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Aug 6, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

The dropdown change doesn't update the table page size in the new <PaginatedTable /> component as a bug introduced in patination utils

@xFJA xFJA linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: b63f637

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 4:59pm
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 4:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 4:59pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 4:59pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 4:59pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 4:59pm

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (fa3a656) to head (b63f637).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         146      146           
  Lines        9630     9630           
  Branches     1020     1020           
=======================================
  Hits         8651     8651           
  Misses        979      979           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PJColombo PJColombo merged commit 7e49c8b into main Aug 25, 2024
14 checks passed
@PJColombo PJColombo deleted the 484-fix-broken-displayed-items-dropdown branch August 25, 2024 15:31
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
@PJColombo PJColombo restored the 484-fix-broken-displayed-items-dropdown branch October 29, 2024 11:30
@PJColombo PJColombo deleted the 484-fix-broken-displayed-items-dropdown branch October 29, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken "Displayed items" dropdown
3 participants