Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fixed blob pagination count #567

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

luis-herasme
Copy link
Member

@luis-herasme luis-herasme commented Sep 12, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Fixed blob pagination count

Related Issue

Closes #535
#528

Screenshots

Before:
image

After:
image

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 1c7f92d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:55pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:55pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:55pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:55pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:55pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:55pm

Copy link
Contributor

github-actions bot commented Sep 12, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.7 KB (🟡 +38.08 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 283.94 KB 81.13%
/stats 347.56 KB 631.25 KB 180.36%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.34 KB 636.03 KB 181.72% (🟢 -4.85%)
/address/[address] 27.3 KB 311 KB 88.86% (🟢 -4.69%)
/blob/[hash] 27.59 KB 311.28 KB 88.94% (🟢 -4.24%)
/blobs 75.98 KB 359.68 KB 102.76% (🟡 +12.33%)
/block/[id] 14.14 KB 297.84 KB 85.10% (🟢 -4.21%)
/blocks 73.68 KB 357.38 KB 102.11% (🟡 +12.32%)
/tx/[hash] 15.54 KB 299.24 KB 85.50% (🟡 +0.65%)
/txs 73.17 KB 356.86 KB 101.96% (🟡 +10.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (3507a88) to head (1c7f92d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         150      150           
  Lines        9933     9933           
  Branches     1035     1035           
=======================================
  Hits         8879     8879           
  Misses       1054     1054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xFJA xFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some scenarios where the pagination count is not working:

Scenery 1

  1. Go to Txs page
  2. Select a date range where there is no records and filter

The pagination is not right and shouldn't allow navigate

image

Scenery 2

  1. Go to Blocks page
  2. Select a slot range with the same value (the result should be 1 item)

The pagination count is not right

image

@PJColombo PJColombo merged commit bbf5111 into main Sep 20, 2024
14 checks passed
@PJColombo PJColombo deleted the fix-blobs-pagination-count branch September 20, 2024 13:56
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination component is not reset after filtering
4 participants