Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavArrows set cursor style based on href availability #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Updates NavArrows component to conditionally set cursor style based on href availability

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 58d5507

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:29pm
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:29pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-gnosis ⬜️ Ignored (Inspect) Oct 31, 2024 9:29pm
blobscan-holesky ⬜️ Ignored (Inspect) Oct 31, 2024 9:29pm
blobscan-mainnet ⬜️ Ignored (Inspect) Oct 31, 2024 9:29pm
blobscan-sepolia ⬜️ Ignored (Inspect) Oct 31, 2024 9:29pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 334.17 KB (🔴 +88.55 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 334.41 KB 95.55%
/stats 347.54 KB 681.71 KB 194.77%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.65 KB 685.82 KB 195.95% (🟢 -5.06%)
/address/[address] 26.8 KB 360.97 KB 103.13% (🟢 -4.83%)
/blob/[hash] 27.5 KB 361.67 KB 103.33% (🟢 -4.26%)
/blobs 76.74 KB 410.91 KB 117.40% (🟡 +12.55%)
/block/[id] 14.19 KB 348.35 KB 99.53% (🟢 -4.19%)
/blocks 74.44 KB 408.61 KB 116.75% (🟡 +12.53%)
/tx/[hash] 16.62 KB 350.79 KB 100.23% (🟡 +0.96%)
/txs 73.94 KB 408.11 KB 116.60% (🟡 +10.53%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (1aa1b7a) to head (58d5507).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   88.93%   89.09%   +0.15%     
==========================================
  Files         154      155       +1     
  Lines       10283    10423     +140     
  Branches     1142     1170      +28     
==========================================
+ Hits         9145     9286     +141     
+ Misses       1138     1137       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -20,13 +20,17 @@ export function NavArrows({
return (
<div className="flex items-center justify-center gap-1">
<Tooltip>
<TooltipTrigger>
<TooltipTrigger
className={prev.href ? "cursor-pointer" : "cursor-default"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a var as this logic is repeated in L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants