Split mapping #127
Merged
Split mapping #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.aggregated_data_dir = io_dir / 'blocks_per_entity' | ||
| self.aggregated_data_dir.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| def aggregate(self, timeframe): |
There was a problem hiding this comment.
I find it a bit confusing to name both functions in the same file aggregate. You could rename this one process. Don't have strong feelings though, so leaving it like that is also fine.
| @@ -20,7 +19,7 @@ def map_from_known_identifiers(self, block): | |||
| """ | |||
| block_identifier = block['identifiers'] | |||
| day = block['timestamp'][:10] | |||
| pool_links = hlp.get_pool_links(self.project_name, day) | |||
| pool_links = hlp.get_pool_links(self.project_name, day) # todo move out of method after updating cardano data | |||
There was a problem hiding this comment.
What is this todo about? I suggest you open a gh issue instead.
| @@ -0,0 +1,18 @@ | |||
| # Aggregator | |||
There was a problem hiding this comment.
You need to activate this page in mkdocs.yml as well.
dimkarakostas
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Split "mapping" into two modules, mapping and aggregation. Now the mapping is only responsible for mapping blocks to entities (and is not dependent on any timeframe), while the aggregator generates the files with information about the distribution of resources to entities for some timeframe.
Also replaced file reading / writing method (json and csv methods instead of simple string parsing) for clarity and easier testing / maintenance.
Left to do: