[WIP]Implement Fast Finality #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: optimize canEnterMaintenance check chore: modify var name chore: optimize code chore: remove unused comment chore: remove unused comment chore: optimize code style feat: use _safeTransferBNB instead to.transfer chore: remove unused line feat: add getSlashThresholds for SlashIndicator and slashCount for BSCValidatorSet feat: remove unused code feat: add getSlashThresholds for SlashIndicator chore: optimize code lint feat: add _forceMaintainingValidatorsExit in updateValidatorSet chore: add comments feat: add maxNumOfMaintaining, maintainSlashScale params fix numOfFelony check while all validators exit maintenance fix: review comments fix: maintainInfo.index issue, use 0 as a `sentinel value` chore: modify comments fix: bug about residual maintainInfoMap is not completely cleared chore: optimize fix about clearing maintainInfoMap feat: add hardhat config chore: modify config chore: modify config chore: add hardhat config feat: finish test case chore: add readme chore: optimize code structure fix: bug about Repeated modified maintainingValidatorSet in loop chore: optimize test fix: add prettier write for test code FIX: review comments fix: accidentally modified code by mistake between `.sol` and `.template` fix: bug that maintaining validators could skip the misdemeanor/felony fix: add modification to template chore: modify case name chore: remove unused code feat: add INIT_MAX_NUM_OF_MAINTAINING, INIT_MAINTAIN_SLASH_SCALE = 2; feat: modify test for init config fix: bug that slash msg could not be sent by BSCValidatorSet feat: modify revert check to return
pythonberg1997
commented
Feb 22, 2022
contracts/SlashIndicator.sol
Outdated
|
|
||
| uint256 index = IBSCValidatorSet(VALIDATOR_CONTRACT_ADDR).currentValidatorSetMap(_evidence.valAddr); | ||
| require(index > 0, "validator not exist") | ||
| ( , , , , , , bytes memory BLSKey) = IBSCValidatorSet(VALIDATOR_CONTRACT_ADDR).currentValidatorSet(index - 1) |
There was a problem hiding this comment.
Way to get the BLS Key of the validator has not yet been decided
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: bnbchain/BEPs#126