Improve build process of grpc bindings #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikDeSmedt
force-pushed
the
better-building-of-grpc-bindings
branch
from
ba49379
to
8f9ea37
Compare
ErikDeSmedt
force-pushed
the
better-building-of-grpc-bindings
branch
from
8f9ea37
to
9a8b274
Compare
|
Following up on our discussion re Google path semantics, I took a look at the generated Today I learned 👍 |
We are generating/compiling python bindings from `.proto`-files. Before this commit the generated protobuf-files did not understand they were a part of the `glclient`-module. This resulted in broken impors which se fixed using `sed` in our Makefile. This commit improves the configuration and voids the need for hacks in our `Makefile`. For more info: See protocolbuffers/protobuf#4176
cdecker
force-pushed
the
better-building-of-grpc-bindings
branch
from
82599a9
to
7553358
Compare
|
Rebased to remove that merge commit, merging asap |
ErikDeSmedt
added a commit
to ErikDeSmedt/greenlight
that referenced
this pull request
Mar 4, 2024
We use pdoc to generate a reference of the python `glclient`-library. We suffered some issues related to missing type-hints. The work-around was to remove the type-hints before generating the docs. I've found 3 causes of warnings. 1. Missing export of `SignerHandle` (See Blockstream#368) 2. Poorly defined imports in auto-generated GRPC-code (See Blockstream#369) 3. pdoc failing to import type from type-stubs (See mitmproxy/pdoc#671) All of these 3 issues have been addressed so we don't need the hack anymore.
cdecker
pushed a commit
to ErikDeSmedt/greenlight
that referenced
this pull request
Jun 6, 2024
We use pdoc to generate a reference of the python `glclient`-library. We suffered some issues related to missing type-hints. The work-around was to remove the type-hints before generating the docs. I've found 3 causes of warnings. 1. Missing export of `SignerHandle` (See Blockstream#368) 2. Poorly defined imports in auto-generated GRPC-code (See Blockstream#369) 3. pdoc failing to import type from type-stubs (See mitmproxy/pdoc#671) All of these 3 issues have been addressed so we don't need the hack anymore.
cdecker
pushed a commit
that referenced
this pull request
Jun 7, 2024
We use pdoc to generate a reference of the python `glclient`-library. We suffered some issues related to missing type-hints. The work-around was to remove the type-hints before generating the docs. I've found 3 causes of warnings. 1. Missing export of `SignerHandle` (See #368) 2. Poorly defined imports in auto-generated GRPC-code (See #369) 3. pdoc failing to import type from type-stubs (See mitmproxy/pdoc#671) All of these 3 issues have been addressed so we don't need the hack anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are generating/compiling python bindings from
.proto-files.Before this commit the generated protobuf-files did not understand they
were a part of the
glclient-module.This resulted in broken imports which we fixed using
sedin ourMakefile.
This commit improves the configuration and voids the need for hacks in
our
Makefile.For more info: See protocolbuffers/protobuf#4176