Impl PartialOrd, Ord for 3 types #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Jul 14, 2023
RangeProof, SurjectionProof and PedersenCommitment The purpose of this is having downstream types like elements::Transaction be usable in ordered collections. bitcoin::Transaction already support this for the same reason
apoelstra
added a commit
that referenced
this pull request
Jul 14, 2023
1e64777 Impl PartialOrd, Ord for 3 types (Riccardo Casatta) Pull request description: RangeProof, SurjectionProof and PedersenCommitment The purpose of this is having downstream types like elements::Transaction be usable in ordered collections. bitcoin::Transaction already support this for the same reason ACKs for top commit: apoelstra: ACK 1e64777 Tree-SHA512: b523ce6f85a255d9c7f8881171fb68ac9e1e21c2ae1429183a469f2fb3379f883cc756e3847c6e489a09ea4bd7fa5eaf7c493c8934c66a71dc319804b8c99847
|
I didn't notice this was already merged, I am opening a new one with
Otherwise with fuzzing there is a double impl |
|
closing because has been merged, what's missing is in |
apoelstra
added a commit
to ElementsProject/rust-elements
that referenced
this pull request
Jul 18, 2023
3eecfad Implement Ord for Transaction (Riccardo Casatta) Pull request description: This haven't any consensuns meaning but it's useful to have transactions in ordered collections ~~depends on BlockstreamResearch/rust-secp256k1-zkp#68 merged ~~draft because needs rust-secp256k1-zkp release BlockstreamResearch/rust-secp256k1-zkp#70 ACKs for top commit: apoelstra: ACK 3eecfad Tree-SHA512: ba4a207baa1a1994dd53b86019f814195e1b40c85ed9e294badd6d4eb3cbd7611347bb1afcb6ab3dc944245526bfe02f420d798bcfa831058211e797dba5ec68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangeProof, SurjectionProof and PedersenCommitment
The purpose of this is having downstream types like elements::Transaction be usable in ordered collections.
bitcoin::Transaction already support this for the same reason