Shows persistent info alert when processing file, and at end of processing #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing The alert is automatically closed when the file is finished processing. A final alert is shown when all files are processed, meaning that the user can start using BH.
cnotin
commented
Feb 20, 2020
| if (isZipSync(path)) { | ||
| var alert = this.props.alert.info( |
There was a problem hiding this comment.
Fix mistake in #302 where the message was shown even for non-zip files
|
Tested locally, and it seems like a good change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert is automatically closed when the file is finished processing.
A final alert is shown when all files are processed, meaning that the user can start using BH. The user has to close this one.
Close #300