Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SHC version #111

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Bump SHC version #111

merged 3 commits into from
Sep 3, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Aug 7, 2024 •
edited
Loading

Description

Bump SHC version.

Update ReadDomainProperties to work with the changes made in this PR: BloodHoundAD/SharpHoundCommon#150

Motivation and Context

Ticket: BP-792

How Has This Been Tested?

Ran it in my lab.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@JonasBK JonasBK added enhancement New feature or request ticketed labels Aug 7, 2024
@JonasBK JonasBK changed the title Add props Additional AD properties Aug 7, 2024
@JonasBK JonasBK changed the title Additional AD properties Bump SHC version Sep 2, 2024
@sircodemane sircodemane merged commit 0dff518 into 2.X Sep 3, 2024
1 check passed
@sircodemane sircodemane deleted the add-props branch September 3, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvazarkar rvazarkar rvazarkar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ticketed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasBK @rvazarkar @sircodemane