Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added customer and supplier information to Batch #1187

Merged
merged 7 commits into from
Apr 28, 2021
Merged

feat: added customer and supplier information to Batch #1187

merged 7 commits into from
Apr 28, 2021

Conversation

MyuddinKhatri
Copy link

@MyuddinKhatri MyuddinKhatri commented Apr 17, 2021

Ref: Asana

Copy link
Member

@neilLasrado neilLasrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have shared feedback with @rvpasari

@@ -134,9 +135,8 @@
},
{
"fieldname": "supplier",
"fieldtype": "Link",
"fieldtype": "Data",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MyuddinKhatri did you change Supplier to a data field ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@@ -100,6 +100,7 @@ def on_submit(self):
self.update_so_in_serial_number()
self.update_package_tag()
self.update_package_tag_is_used()
self.update_batch_with_customer_providing_item()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update_batch_with_customer_provided_item

@@ -689,6 +690,16 @@ def update_stock_ledger(self):

self.make_sl_entries(sl_entries, self.amended_from and 'Yes' or 'No')

def update_batch_with_customer_providing_item(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update_batch_with_customer_provided_item

@neilLasrado neilLasrado merged commit a7a6b41 into Bloomstack:bs-apr-sprint-2 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants