chore: Due date validation in quotation #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrwX
changed the title
hrwX
suggested changes
May 19, 2021
| @@ -850,7 +850,7 @@ def validate_payment_schedule_dates(self): | |||
| if self.doctype == 'Sales Invoice' and self.is_pos: return | |||
|
|
|||
| for d in self.get("payment_schedule"): | |||
| if self.doctype == "Sales Order" and getdate(d.due_date) < getdate(self.transaction_date): | |||
| if self.doctype in ("Sales Invoice", "Quotation") and getdate(d.due_date) < getdate(self.transaction_date): | |||
There was a problem hiding this comment.
- Was there any reason to change sales order to sales invoice ?
|
@hrwX , I referred the above condition, so it was by mistake. I have updated doctype name |
|
@sahil28297 validated with @neilLasrado |
sahil28297
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket Link: https://app.asana.com/0/1200301108563886/1199893804493437