feat: created a weekly holiday notification #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrwX
suggested changes
Jun 9, 2021
sahil28297
suggested changes
Jun 11, 2021
rvpasari
suggested changes
Jun 14, 2021
|
@nehasacher143 Please do the necessary changes as mentioned by Raj |
hrwX
suggested changes
Jun 14, 2021
hrwX
suggested changes
Jun 14, 2021
hrwX
suggested changes
Jun 15, 2021
hrwX
approved these changes
Jun 15, 2021
sahil28297
approved these changes
Jun 15, 2021
shruti2323
pushed a commit
to shruti2323/erpnext
that referenced
this pull request
Jul 6, 2021
* feat: created a weekly holiday notification * fix: made the table for holidays, removed the validation for saturday or sunday * fix: condition to get only valid holiday lists * fix: fixed sider issue * fix: added a enabled field for the holiday list * fixchannged the string formation for email * fix: indentation fixed * fix: moved the enabled field to top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Link: https://app.asana.com/0/1194051119161697/1200407343147914/f