Fix submodel instances due to lack of support in OSPRay; cleanup create- and addModel usage #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record: RenderKit/ospray#256 |
favreau
reviewed
May 24, 2018
| @@ -110,6 +110,11 @@ void OSPRayScene::commit() | |||
| BRAYNS_INFO << "Committing " << modelDescriptor->getName() | |||
| << std::endl; | |||
| _addInstance(_rootModel, impl.getModel(), transformation); | |||
|
|
|||
| #ifndef OSPRAY_SUPPORTS_SUBMODEL_INSTANCES | |||
There was a problem hiding this comment.
From my understanding, OSPRAY_SUPPORTS_SUBMODEL_INSTANCES will apparently never be true :( Do you still want to keep it?
There was a problem hiding this comment.
After I read the ticket of course not :) I'm about to push that.
…te- and addModel usage
|
Super cool PR overall, looking forward to using the new feature :) |
favreau
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.