Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve creating scalar and null dataspaces. #747

Closed
1uc opened this issue May 5, 2023 · 2 comments
Closed

Improve creating scalar and null dataspaces. #747

1uc opened this issue May 5, 2023 · 2 comments
Labels
v3 Anything that needs to be resolved before `v3`.

Comments

@1uc
Copy link
Collaborator

1uc commented May 5, 2023

Currently one needs to

auto dataspace = DataSpace(DataSpace::dataspace_scalar);

to create a scalar dataspace. Note that,

auto dataspace = DataSpace{DataSpace::dataspace_scalar};

creates a one-dimensional simple dataspace with of shape [0]. It would be nicer to allow something like:

auto dataspace = DataSpace::Scalar();
auto dataspace = ScalarSpace();
auto dataspace = DataSpace::createScalar();
@1uc 1uc added the v3 Anything that needs to be resolved before `v3`. label Nov 24, 2023
@1uc
Copy link
Collaborator Author

1uc commented Nov 24, 2023

Removing/changing DataSpace::dataspace_scalar might be something to consider for v3.

@1uc
Copy link
Collaborator Author

1uc commented Feb 12, 2024

Complete since merging: #900.

@1uc 1uc closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Anything that needs to be resolved before `v3`.
Projects
None yet
Development

No branches or pull requests

1 participant