Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named ctors for scalar and null dataspaces. #899

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 18, 2023

The issue is that:

DataSpace{DataSpace::dataspace_scalar};
DataSpace{DataSpace::dataspace_null};

are a simple dataspace with 0 elements and a simple dataspace with one element, respectively. This provides a safer alternative.

@1uc
Copy link
Collaborator Author

1uc commented Dec 18, 2023

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c660174) 85.34% compared to head (6acdc79) 85.38%.
Report is 1 commits behind head on master.

Files Patch % Lines
include/highfive/bits/h5s_wrapper.hpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   85.34%   85.38%   +0.03%     
==========================================
  Files          84       84              
  Lines        5508     5527      +19     
==========================================
+ Hits         4701     4719      +18     
- Misses        807      808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 18, 2023 09:32
@1uc
Copy link
Collaborator Author

1uc commented Dec 18, 2023

Precedence:

static const PropertyList<T>& Default() noexcept {

static DataSpace From(const T& value);

static DataSpace FromCharArrayStrings(const char (&string_array)[N][Width]);

@1uc 1uc merged commit 5e1a92f into master Dec 18, 2023
36 checks passed
@1uc 1uc deleted the 1uc/named-ctor-dataspace branch December 18, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants