Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cmake detection quietness, and adhere to standard procedure #701

Merged
merged 1 commit into from
May 4, 2023

Conversation

ferdonline
Copy link
Contributor

Description

The packageConfig.cmake was not respecting QUIET request. Further, it seems that we were not calling check_required_components which is pretty standard to validate component request.

Fixes #593

How to test this?

Tested locally, launching test_project_integration.sh

cd HighFive/tests
bash test_project_integration.sh

@codecov-commenter
Copy link

Codecov Report

Merging #701 (a4eb866) into master (ce97dd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          67       67           
  Lines        4383     4383           
=======================================
  Hits         3593     3593           
  Misses        790      790           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1uc
Copy link
Collaborator

1uc commented Mar 31, 2023

I don't have a strong opinion about this PR. However, I've just spent over 3 days trying to understand what HighFive CMake does; and how it interacts with Spack. Therefore, I'd prefer if this wasn't part of 2.7.0.

Generally, I think we need to burn down our CMake and start over with something closer to #257. For that reason I'm not sure it's worth merging it. There's a nice trick in here that we can definitely use.

@1uc 1uc merged commit d26fac6 into master May 4, 2023
@1uc 1uc deleted the cmake_detection_config branch May 4, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed package is noisy when found by CMake
4 participants