Improve Cmake detection quietness, and adhere to standard procedure #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
packageConfig.cmake
was not respecting QUIET request. Further, it seems that we were not callingcheck_required_components
which is pretty standard to validate component request.Fixes #593
How to test this?
Tested locally, launching
test_project_integration.sh
cd HighFive/tests bash test_project_integration.sh