Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try last version 1.14.1 #753

Merged
merged 9 commits into from
May 26, 2023
Merged

Try last version 1.14.1 #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5f772d8
Try last version 1.14.1
May 12, 2023
1fdb1da
1_10_10
May 12, 2023
99e6261
Merge remote-tracking branch 'origin/master'
May 23, 2023
e717d10
Lower values
May 23, 2023
e786bcb
Split test and build
May 25, 2023
f166661
Fix tests
May 25, 2023
29402bf
Fix coverage
May 25, 2023
05163d5
Fix coverage
May 25, 2023
3b0dba8
Build HDF5 without asserts.
1uc May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
hdf5_version : [ hdf5-1_8_23, hdf5-1_10_9, hdf5-1_12_2, hdf5-1_14_0 ]
hdf5_version : [ hdf5-1_8_23, hdf5-1_10_10, hdf5-1_12_2, hdf5-1_14_1 ]

steps:
- uses: actions/checkout@v3
Expand All @@ -102,7 +102,7 @@ jobs:
wget https://github.com/HDFGroup/hdf5/archive/refs/tags/${{ matrix.hdf5_version }}.tar.gz --output-document hdf5.tar.gz
tar xf hdf5.tar.gz
mkdir -p hdf5-${{ matrix.hdf5_version }}/BUILD && cd hdf5-${{ matrix.hdf5_version }}/BUILD
cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=$HOME/${{ matrix.hdf5_version }} -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DUSE_LIBAEC=ON
cmake .. -DCMAKE_BUILD_TYPE=Release -GNinja -DCMAKE_INSTALL_PREFIX=$HOME/${{ matrix.hdf5_version }} -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DUSE_LIBAEC=ON
ninja && ninja install

- name: Build
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
fetch-depth: 2
submodules: true

- name: Build and test for code coverage
- name: Build for code coverage
run: |
CMAKE_OPTIONS=(
-GNinja
Expand All @@ -54,11 +54,12 @@ jobs:
-DCMAKE_CXX_FLAGS="-coverage -O0"
)
source $GITHUB_WORKSPACE/.github/build.sh
cd $HIGHFIVE_BUILD
(cd $GITHUB_WORKSPACE; lcov --capture --initial --directory . --no-external --output-file build/coverage-base.info)
cmake --build $HIGHFIVE_BUILD --target test
(cd $GITHUB_WORKSPACE; lcov --capture --directory . --no-external --output-file build/coverage-run.info)
lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info
- name: Test for code coverage
run: |
lcov --capture --initial --directory . --no-external --output-file build/coverage-base.info
(cd build; cmake --build . --target test)
lcov --capture --directory . --no-external --output-file build/coverage-run.info
(cd build; lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info)
- uses: codecov/codecov-action@v3
with:
files: ./build/coverage-combined.info
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/tests_high_five_base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,12 +291,12 @@ TEST_CASE("Test group properties") {
File file(file_name, File::Truncate, fapl);

GroupCreateProps props;
props.add(EstimatedLinkInfo(1000, 500));
props.add(EstimatedLinkInfo(10, 60));
alkino marked this conversation as resolved.
Show resolved Hide resolved
auto group = file.createGroup("g", props);
auto sizes = group.getEstimatedLinkInfo();

CHECK(sizes.first == 1000);
CHECK(sizes.second == 500);
CHECK(sizes.first == 10);
CHECK(sizes.second == 60);
}

TEST_CASE("Test allocation time") {
Expand Down