Macro free dependency handling. #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/restructure-headers
branch
4 times, most recently
from
fa31058 to
a6157a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 89 89
Lines 5870 5870
=======================================
Hits 5046 5046
Misses 824 824 ☔ View full report in Codecov by Sentry. |
matz-e
previously approved these changes
Dec 14, 2023
|
The bulk of the refactoring can already be merged, see #898. |
1uc
force-pushed
the
1uc/restructure-headers
branch
2 times, most recently
from
7c03c1c to
180ed8c
Compare
matz-e
approved these changes
Dec 21, 2023
In a prior commit the sources were restructured such that each optional
dependency is contained in separate files. This commit removes the
macros that controlled which dependencies are included.
To include the optional dependency Boost use:
#include <highfive/highfive.hpp>
#include <highfive/boost.hpp>
the order doesn't matter.
1uc
force-pushed
the
1uc/restructure-headers
branch
from
180ed8c to
1ef161e
Compare
alkino
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch of how we could reorganize our headers to allow each code to pick their dependencies simply by choosing which headers they include. This is similar to how pybind11 handles their convertors between Python types and say STL containers.