No constexpr rank via constexpr min-max rank. #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
changed the title
1uc
force-pushed
the
1uc/non-constexpr-rank
branch
from
b721d4b to
d881187
Compare
The commit removes the requirement for a constexpr rank. Instead
containers need a minimum and maximum constexpr rank.
The difficulties are:
* Empty arrays can't figure out their runtime rank. This is an issue
when deducing the dimension when writing to disk. The "solution" is
to deduce with lowest rank possible.
1uc
force-pushed
the
1uc/non-constexpr-rank
branch
from
d881187 to
e3d9031
Compare
|
This allows us to do |
matz-e
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes the requirement for a constexpr rank. Instead
containers need a minimum and maximum constexpr rank.
The difficulties are:
when deducing the dimension when writing to disk. The "solution" is
to deduce with lowest rank possible.