Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated viewer module #1032

Merged
merged 4 commits into from
May 3, 2022
Merged

Remove deprecated viewer module #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42e6065
Remove deprecated viewer module
eleftherioszisis Apr 29, 2022
0af5ed9
Hide more specific plotting functions from view
eleftherioszisis Apr 29, 2022
917b82e
Remove deprecated viewer tests
eleftherioszisis Apr 29, 2022
4d519a7
Update CHANGELOG
May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Changelog
=========

Version 4.0.0
-------------

- ``neurom.view.[plot_tree|plot_tree3d|plot_soma|plot_soma3D]`` were hidden from the
neurom.view module. They can still be imported from neurom.view.matplotlib_impl.
- Deprecated modules and classes were removed.


Version 3.2.0
-------------

Expand Down
2 changes: 0 additions & 2 deletions neurom/view/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,4 @@

"""View tools to visualize morphologies."""
from neurom.view.matplotlib_impl import (plot_morph, plot_morph3d,
plot_tree, plot_tree3d,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeplf , just to verify after our discussion, we do want to hide these. right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see their utility, but on the other hand, they're part of the API, and someone may have used them.

I guess we have 3 choices:

  1. Leave things how they are
  2. Mark them as deprecated, and remove them later
  3. Remove them now, explain in Changelog that they just aren't as visible, and to give feedback if they are needed.

I think 3 is a fine compromise, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is good to go now, right?

plot_soma, plot_soma3d,
plot_dendrogram)
136 changes: 0 additions & 136 deletions neurom/viewer.py
View file
Open in desktop

This file was deleted.

131 changes: 0 additions & 131 deletions tests/test_viewer.py
View file
Open in desktop

This file was deleted.