Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internals
Update Ember to 4.0
Run
ember-cli-update --to 4.0
.Renamed the workflow
validate-pr
toci
to align with the blueprint.The logic of the website was based on
renderTemplate
, but this feature has been removed. To replace it, I implemented a new approach based on components, but the usage of{{component}}
helper makes it incompatible with Embroider, so it's not future-proof. I need a way to import components without hardcoding an extra list of names because that would be too complicated to handle. The new approach highlighted the fact that 2 projects were already missing in theprojects.json
, just because the existing panels and theprojects.json
are two different source of truth.The
store
is no longer injected by default in all routes, so I need to inject it explicitly using@service store
syntax.equals
replaced bystrictEquals
to be more strict.Update Ember to 4.12
Run
ember-cli-update --to 4.12
. This one is easier to handle as it's the latest minor LTS for 4.x, so I take the chance to fix a couple of deprecations before moving forward.The latest
ember-cli-bootstrap
is compatible with Ember >= 4.8, so now is the right moment to update all the CSS-related dependencies to fix a couple of deprecations. The remaining deprecations come from bootstrap. It seems that the way the SCSS is processed makes a declaration) appear after a nested-rule related to the same property, which has been deprecated by sass because the future ordering they want to put in place would impact the resulting style. This might be fixed in bootstrap v5.3.4.The blueprint now includes CSS linting with
stylelint-config-standard
, but this plugin is for CSS, and I use SCSS. As described in stylelint documentation, I replaced this plugin withstylelint-config-standard-scss
, which allows me to get a bunch of lint errors on myapp.scss
file.New lint rules highlight accessibility issues with the videos, I need to specify it's just background music.
The method transitionTo is deprecated on
Route
and should now be used through the router service.