Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember #47

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Update Ember #47

merged 2 commits into from
Jul 27, 2024

Conversation

BlueCutOfficial
Copy link
Owner

@BlueCutOfficial BlueCutOfficial commented Jul 26, 2024

Internals

Update Ember to 4.0

  1. Run ember-cli-update --to 4.0.

  2. Renamed the workflow validate-pr to ci to align with the blueprint.

  3. The logic of the website was based on renderTemplate, but this feature has been removed. To replace it, I implemented a new approach based on components, but the usage of {{component}} helper makes it incompatible with Embroider, so it's not future-proof. I need a way to import components without hardcoding an extra list of names because that would be too complicated to handle. The new approach highlighted the fact that 2 projects were already missing in the projects.json, just because the existing panels and the projects.json are two different source of truth.

  4. The store is no longer injected by default in all routes, so I need to inject it explicitly using @service store syntax.

  5. equals replaced by strictEquals to be more strict.

Update Ember to 4.12

  1. Run ember-cli-update --to 4.12. This one is easier to handle as it's the latest minor LTS for 4.x, so I take the chance to fix a couple of deprecations before moving forward.

  2. The latest ember-cli-bootstrap is compatible with Ember >= 4.8, so now is the right moment to update all the CSS-related dependencies to fix a couple of deprecations. The remaining deprecations come from bootstrap. It seems that the way the SCSS is processed makes a declaration) appear after a nested-rule related to the same property, which has been deprecated by sass because the future ordering they want to put in place would impact the resulting style. This might be fixed in bootstrap v5.3.4.

  3. The blueprint now includes CSS linting with stylelint-config-standard, but this plugin is for CSS, and I use SCSS. As described in stylelint documentation, I replaced this plugin with stylelint-config-standard-scss, which allows me to get a bunch of lint errors on my app.scss file.

  4. New lint rules highlight accessibility issues with the videos, I need to specify it's just background music.

  5. The method transitionTo is deprecated on Route and should now be used through the router service.

@BlueCutOfficial BlueCutOfficial force-pushed the update-ember branch 2 times, most recently from fb41393 to 64aeebc Compare July 27, 2024 15:14
Copy link

🔴 Total coverage is lower than the default branch

Lines Branches Functions Statements
95.83% (+1.29%) 81.25% (+3.48%) 90.00% (-0.47%) 95.83% (+1.29%)

Detailed report

click to open the diff coverage report
File Lines Branches Functions Statements
app/routing/project-route.js 100.00% (+16.67%) 100.00% (+50.00%) 100.00% 100.00% (+16.67%)

@BlueCutOfficial BlueCutOfficial merged commit af4788a into master Jul 27, 2024
1 check failed
@BlueCutOfficial BlueCutOfficial deleted the update-ember branch July 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant