-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unpack variants option #20
Conversation
5710372
to
749ebb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we are using in Bleak, so it could be nice to have it built-in to dbus-fast.
Although I could not understand what "remove signatures" meant until I read all of the code. In Bleak we called this "unpack_variants" since that is basically what it is doing. When I read "remove signatures", I thought this was doing some really low-level thing with the d-bus message itself.
Codecov ReportBase: 80.78% // Head: 80.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 80.78% 80.88% +0.09%
==========================================
Files 24 24
Lines 2800 2835 +35
Branches 602 616 +14
==========================================
+ Hits 2262 2293 +31
Misses 334 334
- Partials 204 208 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Unpack variants is a good name @dlech . As I mentioned above I was really just moving this code from supervisor into the library as it seemed really useful for everyone and kept the names we were using the same. But I'll rename it, that does make more sense. |
So for the codecov check, its basically failing that because I also modified the |
I think we are missing a library being installed in the CI. We should probably fix that first. I'll see if I can fix it before I go to sleep but getting late here so not if I can before sleep. |
GI tests should work now. CI should be a bit faster as well as caching will be turned on with this PR I'm too tired to be sure I got everything right with the jet lag so I didn't merge it, but feel free if it looks ok. g'night |
1a7a4ad
to
93ed41d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to address #20 (comment) before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
17e4a01
to
0f3cfd2
Compare
0f3cfd2
to
8bd423d
Compare
Add a flag to unpack variants in outputs. Supported this flag in all methods of the proxy interface (methods, properties and signals).
Support for this flag was not implemented in
MessageBus.call
. We could do this but it seemed like that one should remain raw. Also the wrappers in Proxy Interface won't work correctly if variants are unpacked by call so they have to handle it separately anyway.