-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve asyncio write performance #29
Conversation
Codecov ReportBase: 81.23% // Head: 81.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 81.23% 81.01% -0.23%
==========================================
Files 24 24
Lines 2840 2849 +9
Branches 619 623 +4
==========================================
+ Hits 2307 2308 +1
- Misses 327 330 +3
- Partials 206 211 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
However with this change ~99% of writes don't need to be scheduled and can happen right away so it helps quite a bit with the latency |
Similar to https://github.com/python/cpython/blob/2a50772b63d7bc4ef97d16e9bcc53455c301b0ea/Lib/asyncio/selector_events.py?rgh-link-date=2022-09-24T02%3A51%3A37Z#L914
With this change ~99% of writes don't need to be scheduled and can happen right away so it helps quite a bit with the latency
I was able to get sub 1s connection times on my yale locks with this change
Previously the best I could do was slightly > 1s
fixes #28