Bringing realm roles and permissions up to date on a fresh branch #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/boards/queries.ts
Outdated
| }[] | ||
| | null | ||
| > => { | ||
| try { |
There was a problem hiding this comment.
No need to try/catch anymore in these. Just let the exception rip.
server/realms/routes.ts
Outdated
| }); | ||
| } catch (e) { | ||
| error(e); | ||
| res.status(500).json({ |
There was a problem hiding this comment.
Instead of doing this, you can directly throw a 500 error and it will be handled by the server:
boba-backend/server/realms/routes.ts
Line 486 in dde9b0c
essential-randomness
requested changes
Oct 11, 2023
essential-randomness
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving over changes from PR 126 to allow admin/owner role to view realm and board roles. Addresses most of BobaBoard/issues/issues/133
Also updates relevant Zod types.