Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Classic renderer] Pixel aspect ratio is not an exact 8:7, causing uneven rendering #102

Open
getphobo opened this issue Sep 3, 2023 · 0 comments
Labels
bug Something isn't working pending release The task is completed but not yet part of a release

Comments

@getphobo
Copy link

getphobo commented Sep 3, 2023

Here's an issue I found when experimenting with different display resolutions and the Vulkan and classic renderer -- I was looking to get the most even-looking picture, and this is what I got.

When using the classic renderer, with the 'Logical display width' being set to 292.571 (8:7 * 256) and 'Render height' to 1680 (7 * 240), it is always exactly one pixel being rendered less wide than all the others, causing the 256 emulated pixels to become 2047 pixels wide instead of the 2048 I would get on Vulkan.

That would mean that there is some rounding issue or a wrong factor being applied. For a perfect 8:7 pixel aspect ratio, the classic renderer would have to occupy 2048 * 1680 pixels for the 256 * 240 px menu background screen.

This seems to be the reason why the bottom bar is never rendered evenly. Perhaps you might want to look into this?

@BodbDearg BodbDearg added the bug Something isn't working label Nov 13, 2023
BodbDearg added a commit that referenced this issue Sep 24, 2024
Round up to the next pixel size if dealing fractional pixel output areas. This makes the behavior consistent with the SDL/software-only video backend. Also addresses #102.
@BodbDearg BodbDearg added the pending release The task is completed but not yet part of a release label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending release The task is completed but not yet part of a release
Projects
None yet
Development

No branches or pull requests

2 participants