feat: hardware wallet support #684
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michael1011
force-pushed
the
ledger-support
branch
from
5a4b3a4
to
3401d8d
Compare
michael1011
force-pushed
the
ledger-support
branch
from
3401d8d
to
f76c5b8
Compare
|
My nano s is connected and unlocked (it's recognized by Ledger Live and also Sparrow) but can't click "Ledger". What am I missing? EDIT: seems to be a FF issue (missing WebHID). So the ledger button should throw sth like "Browser not supported" when clicking |
|
If the wrong (not Ethereum/RSK) app open on Ledger it throws |
|
If no app open at all - Ledger doesn't show in the dialogue. I bet some users wouldn't know why. I would always bring up this menu with ALL available options (Trezor, Ledger, Metamask) so that you can throw proper errors when clicking them (never disable click but throw "No Trezor wallet connected": It's common UX to bring up a "select wallet" menu |
|
Hmm soo connecting (which prompts me to open the ethereum app on my ledger) sometimes work sometimes hangs in this state forever (ethereum app on ledger is open): |
|
Also, when I "disconnect" "Create Atomic Swap button is still enabled and let's me create the swap. It should be disabled. Now I am in a state where claiming my swap doesn't work because ledger is disconnected. As this can happen for other reasons too, this claiming step needs a "connect" button if the wallet is disconnected. EDIT: when refreshing it switches to "connect to swap address". Hmm maybe we can hint on the refresh? |
|
I connected my ledger again then it was hanging in this state without continuing |
|
Then I refreshed, connected to swap address again, pressed continue and then this one My ledger showing Error: Blind signing must be enabled in settings which makes sense as I never used this Ledger for Ethereum transactions before but Web App needs to catch this error and show this properly: |
|
Refreshing, again hanging here not succeeding to connect I tried several times no luck, always closing Ethereum app on my ledger before refreshing the site so that it prompted me to open it (which I did). When leaving Ethereum App open, refreshing - it finally succeeded. I reproduced several more times: when I have Ethereum app closed and Ledger prompts me to open it, Boltz Web App hangs. |
|
Then again this one, want me to enable blind signing to continue? @michael1011
|
|
PS: Ethereum App Version is 1.12.1 |
|
Blind signing works now, but please hint me to look at my ledger and choose "accept risk and sign" |
|
Ethereum app on Ledger crashed twice and I had to retry but finally made it: |
|
good |
|
Now I can't make my nano s to appear in the HID list at all. No matter if with ethereum app open or not. I think I'll leave it be for today. |
Closes #680
We should lazy load the LedgerSigner, because its dependencies are heavy