Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor coloration issue #15

Closed
Mumrik93 opened this issue May 17, 2019 · 13 comments
Closed

minor coloration issue #15

Mumrik93 opened this issue May 17, 2019 · 13 comments

Comments

@Mumrik93
Copy link

Love the new update, the coloured icons look great! I have an issue thou, mostly minor, but some of the icons have a bit of a color issue, a few are very bright while some are unusually dark.

I took a screenshot of my desktop while using the icons. You can see that the trash bin is Very dark, whilst the Mailspring (my mail client) is very bright. Lastly on the right side of my panel you can see the f.lux icon is very dark, whilst all other icons are a nicely (and clear) white.
No major issue, but they are issues that might nag people (me included) in the long run.

Skärmbild från 2019-05-18 00-43-53
Skärmbild från 2019-05-18 00-57-31

@gusbemacbe
Copy link
Collaborator

Hej och god kväll @Mumrik93 !

I could see the flux and trash icons, I will fix them.

But I did not see the Mailspring icon, are you referring to yellow-and-white icon, byside Discord and Telegram?

@Bonandry
Copy link
Owner

@gusbemacbe nella versione BETA ho colorato in bianco le icone del pannello e una nuova icona cestino

@Mumrik93
Copy link
Author

Mumrik93 commented May 18, 2019

Tjenare och go'middag @gusbemacbe
It sure is. I think the stock Mailspring icon would fit pretty well into the GNOME++ theme (not that the current one wont work either, if only the brightness was turned down a little bit)

Ps: did not think of this before, but a Steam-folder would be nice too, completely unnecessary but would pretty nice to have.

Pps: The update-icon in the system-tray is still the stock one, it would be pretty cool if you used another one, the stock one is pretty boring to be honest. The Papirus and Korla icon-themes have a really nice system-tray icons for the updater. (reference the first pic i uploaded, it uses the papirus system-tray icon, while the second pic uses the Gnome++ icon)

@gusbemacbe
Copy link
Collaborator

gusbemacbe commented May 18, 2019

It sure is. I think the stock Mailspring icon would fit pretty well into the GNOME++ theme (not that the current one wont work either, if only the brightness was turned down a little bit)

I will explain to @Bonandry .

@Bonandry , per favore, dobbiamo ridisegnare un'icona specifica per Mailspring. Utilizza i colori con forme di blu. Le forme di bianco devono esse meno luminose.

Ps: did not think of this before, but a Steam-folder would be nice too, completely unnecessary but would pretty nice to have.

We will add a new folder. My Suru++ 30 and @Bonandry's Suru++ Ubuntu have a Steam folder.

@Bonandry , andiamo creare una nuova icona di places con il nome di folder-steam.

Pps: The update-icon in the system-tray is still the stock one, it would be pretty cool if you used another one, the stock one is pretty boring to be honest. The Papirus and Korla icon-themes have a really nice system-tray icons for the updater. (reference the first pic i uploaded, it uses the papirus system-tray icon, while the second pic uses the Gnome++ icon)

Are you suggesting we use purely GNOME system-tray icon or Papirus icon?

If you want Papirus system-tray icons, I will talk with @Bonandry and he will decide. My Suru++ 30 follows the Papirus philosophy and style, it uses Papirus system-tray icons, the difference between Suru++ and Papirus is that, Papirus is flat and Suru++ is cyberpunk and futuristic.

Tack så mycket for your answer!

@Bonandry
Copy link
Owner

added mailspring folder-steam in gnome beta

@gusbemacbe
Copy link
Collaborator

@Mumrik93

Here are new icons of Mailspring and Steam folder:

folder steam

mailspring

Did you like them?

@Mumrik93
Copy link
Author

Hello again, no no i did not mean that you would copy the system-tray icons from papirus, i meant specifically the "update-icon" in the system-tray. It still uses the stock icon, which looks a bit out-of-place

@Mumrik93
Copy link
Author

@gusbemacbe Oh those looks beautiful <3 Please use them!

@gusbemacbe
Copy link
Collaborator

@Mumrik93

I got it. GNOME++ does not have this icon. I will search for Papirus update icons to get missed icons.

@Mumrik93
Copy link
Author

I just found out that also the caffeine indicator (in the system-tray) is unusually dark, just like the f.lux icon. Maybe there are more icons then that who's very dark?

Skärmbild från 2019-05-18 21-23-58

@gusbemacbe
Copy link
Collaborator

Hej @Mumrik93 !

The most of updated icons and several improved icons are in the private repository. As there are not new ideas, I must pull upstream it to this repository in the branch beta tomorrow. Why tomorrow? Because @Bonandry and I need to symlink many similiar icons to optimise the pack size.

gusbemacbe added a commit that referenced this issue May 31, 2019
…privato into beta

Beta – See the description

* Most of icons have been improved and reimaged with pure Adwaita look (#11)
* Most of icons have been resymlinked
* Mailspring and Steam folder have been added and improved (#15)
* Added missed update icons (#15)
* Trash icon has been improved (#15)
* Fixed wrong icons – disco-rigido and gioco icons (#16)
* Most of “actions” icons have been de-imaged with Suru and reimaged with Papirus style (#11)
* New Boxy SVG, Drawing, Figma, IGdm, Marker, network and printer icons
* Panel icons have been recolored
* Fixed some icons: aiuto, audacity, pdf-symbolic, video-x-generic
* Fixed actions icons
@gusbemacbe
Copy link
Collaborator

Tjenare och go'middag @Mumrik93

I have just upstreamed it to the beta branch.

@gusbemacbe
Copy link
Collaborator

Hej, I have just released it officially. You can download now with these fixed problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants