-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Kvantum/KvYaru #32
Comments
Hello @ryu-ketsueki ! Before, Yaru++ was designed exclusively to light Ubuntu. I, as co-author and the repo's author had an agreement that Yaru++ should be expanded to be supported in many non-Ubuntu and non-GNOME distributions, non-light and mixed themes, but only the folder If you want it to be solved quickly, as you know how to do it because you showed us how you solved in the third screenshot, you are free to clone our repo, and make a PR. |
Sadly that was a bug with Plasma's icons. I applied Yaru++-Dark after Yaru++ while keeping Dolphin's window open, making only the icons on the toolbar change. Everything changes to the recently applied icon pack if I close and reopen the window. But I will see what I can do. It would appear that some icons are showing grey instead of black. If I learn why they are like that, I may be use it to have them turn all white. |
Toolbar icons belong to Was it what you were trying to test? I would create a new alternative icons theme as I doubt that the actions and status icons with white colour work in the toolbar, menu bar, bar menu of other apps. |
Hello @ryu-ketsueki ! I have just added compatibility with Kvantum. It is on the branch |
There are many icons missing. I think it may be a problem with inherits. As for the icons already here, few of them are on the right colors. I tested using KvMojaveMixed, which used the mixed light/dark appearance from the original KvYaru. The new one seem to have abandoned it completely. I will see if I can find a similar one and also has the Mixed light/dark appearance as the default Yaru for Ubuntu. Here is an image of my first test. The dock icons are icons I had set manually, so they are not defined by icon pack |
Hello @ryu-ketsueki I'll investigate this issue. |
I finally investigated the cause: Because you did not copy Still I have to improve some icons because some of them are still white somewhere. |
I have just updated the |
|
Since you do not answer anymore, I must close this issue. |
I apologize, I do not have much time to invest on this, even because now KvYaru does not use a dark toolbar anymore, so this would not be necessary anymore. But from what I could tell in the last times I used Yaru++, the kYaru++ is working well. |
@ryu-ketsueki, I am glad it worked. |
I'm using this icon pack with KvYaru as theme for KDE Plasma. For both Yaru++ and Yaru++-Dark, the icons are not inverted for the toolbars. This is an issue only with Yaru++ Icon Packs, as the other icon packs such as Breeze, Qogir and others, display the icons properly on the toolbars.
This is how it is showing: https://i.postimg.cc/2yFLpF4X/Screenshot-20191024-172604.png
This is how the Yaru++-Dark shows: https://i.postimg.cc/kMxbt9kF/Screenshot-20191024-172627.png
This is how it is supposed to show: https://i.postimg.cc/Wbzscw6F/Screenshot-20191024-173108.png
The text was updated successfully, but these errors were encountered: