Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor annoyance: icons sharpness #35

Closed
ghost opened this issue Oct 26, 2019 · 22 comments
Closed

Minor annoyance: icons sharpness #35

ghost opened this issue Oct 26, 2019 · 22 comments

Comments

@ghost
Copy link

ghost commented Oct 26, 2019

Hey :)

Nothing big, but maybe you could try to work on that later, icons aren't as crisp as the default Yaru ones. See this side by side comparison screenshot taken in Ubuntu 19.10 (open in full size):

Capture d’écran de 2019-10-26 12-51-04

EDIT: display is 1080p

@gusbemacbe
Copy link
Collaborator

The index.theme was copied from Suru++ Ubuntu which contained a lot and lot of bug, it is why it does not have apps/32 and apps/48, I always told the Italian guy not to copy Suru++ Ubuntu, and I had to spend 4 months, correcting both his repositories.

I will work on it. But firstly I need to test my template on Void.

@gusbemacbe
Copy link
Collaborator

Ready, @DarthWound !

@gusbemacbe
Copy link
Collaborator

I understood now. In his old Yaru++, you can compare:

image

image

@gusbemacbe
Copy link
Collaborator

gusbemacbe commented Oct 26, 2019

If the new beta commit pleases or satisfies you, we will not need to redo the "pure 32/48 px" icons. But if not, I (not the Italian guy) will redo next months.

@ghost
Copy link
Author

ghost commented Oct 26, 2019 via email

@ghost
Copy link
Author

ghost commented Oct 27, 2019

Some icons are slightly better, yes :-)

But in the dock for example I don't see any improvements:

Capture d’écran de 2019-10-27 15-28-50

Well, don't worry, it doesn't matter that much, it's just that IMHO default Yaru edges are more clear. But I prefer having a complete theme for all my programs instead of an inconsistent mix.

@gusbemacbe
Copy link
Collaborator

But in the dock for example I don't see any improvements

Which improvements did you not see?

@ghost
Copy link
Author

ghost commented Oct 28, 2019

Well, they are a bit more clear I agree, but look at original Yaru like in my 1st screenshot. The default set has more relief, see the edges?

Maybe it was intentional to make Yaru++ icons very flat though? In my head Yaru++ concept was more like "Yaru extended", same as the original but with consistent look for every program.

@gusbemacbe
Copy link
Collaborator

Well, they are a bit more clear I agree, but look at original Yaru like in my 1st screenshot. The default set has more relief, see the edges?

Yes, I did. But to end the inconsistent mix, do you prefer the icons with edges (original Yaru as in the left of 1st screenshot) or without edges (Yaru++ beta without edges)? Or 32 and 48 px with relief and edges and 64 px and scalable without relief and edges? Or all 24 (maybe or not), 32, 48, 64 and scalable without edges and relief?

@ghost
Copy link
Author

ghost commented Oct 28, 2019

Personally, I'm not against flat/material design, but I usually think it is better if an extended set follow the design principles of its source, except if the source is ugly of course. Ubuntu desktop team keep a bit of relief everywhere, even in Yaru-GTK, with subtle gradients and shadows.

But, as I said I don't mind that much, it was just a suggestion, something for you to think about, I don't know what people prefer and I never ask something only for myself :)

Maybe @Feichtmeier and @clobrano and others could give their opinion on this topic? I know they can't endorse a third-party theme though.

If Yaru++ users and creators prefer the flatter look, I'm totally ok with that! Yaru++ is incredibly essential for Ubuntu users in my opinion.


Just a not related request by the way, could you make the nose reflection in the GIMP icon darker than white? Maybe something like #9f9f9f for example.

@gusbemacbe
Copy link
Collaborator

gusbemacbe commented Oct 28, 2019

Personally, I'm not against flat/material design, but I usually think it is better if an extended set follow the design principles of its source, except if the source is ugly of course.

To be honest quite, I and the Italian guy (author of this repository) find 32px and 48px icons (edges and relief) very ugly, so we replace them with 64px or scalable icons. But I am not sure that the users of Yaru++ want our icons theme to be exactly like Canonical's Yaru or prefer the icons theme without edges and relief.

Maybe @Feichtmeier and @clobrano and others could give their opinion on this topic? I know they can't endorse a third-party theme though.

Yes, they can not add, it is why their icons theme is licenced under CC BY-SA/GPL3, then we can fork it and add how many icons we want. I know that Canonical and GNOME developers are against it due to that letter in which criticises the customisation.

Be aware that I have been once a contributor of Canonical's Yaru. :-). Check https://github.com/ubuntu/yaru/commits?author=gusbemacbe.

Just a not related request by the way, could you make the nose reflection in the GIMP icon darker than white? Maybe something like #9f9f9f for example.

The 16px or scalable icon?

@ghost
Copy link
Author

ghost commented Oct 28, 2019

The scalable icon.

@gusbemacbe
Copy link
Collaborator

I will ask @Bonandry.

@Bonandry, puoi rendere più scuro il riflesso del naso nell'icona di GIMP con il colore di #9f9f9f?

@clobrano
Copy link

I know that Canonical and GNOME developers are against it due to that letter in which criticises the customisation.

LOL, the letter is mainly against Canonical :D

@Bonandry
Copy link
Owner

Bonandry commented Nov 5, 2019

@gusbemacbe OK, fatto

@gusbemacbe
Copy link
Collaborator

Hi @DarthWound !

As @Bonandry wants to keep the sharpened icons in the Yaru++, I have just created the new theme Yaru++ Smooth, which does not contain sharpened icons. Please use it from the branch gusbemacbe. If you need a dark theme without sharpened icons, please let me know.

@ghost
Copy link
Author

ghost commented Feb 24, 2020

Awesome, thanks! Sorry for late reply, had a lot of work IRL :-)

@gusbemacbe
Copy link
Collaborator

@DarthWound

You're welcome. Please check the FRench translation in index.theme, I am not sure if my French translation is correct, because I did not find the right words for "sharpness" and "smoothness".

@ghost
Copy link
Author

ghost commented Feb 24, 2020

The french for "smooth" is usually "lisse" here. For "sharp" you can use "net" or "précis" in this context.

@gusbemacbe
Copy link
Collaborator

So sharp icons = icônes nets ou précises and smooth icons = icônes lisses, @DarthWound ?

@ghost
Copy link
Author

ghost commented Feb 24, 2020

Sharp icons -> Icônes nettes
Smooth icons -> Icônes lisses

@gusbemacbe
Copy link
Collaborator

@DarthWound

Please test Yaru++ Smooth in the branch gusbemacbe if it meets your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants